lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 15 Nov 2018 12:54:31 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Li Dongyang <dongyangli@....com>
Cc:     linux-ext4@...r.kernel.org, Andreas Dilger <adilger@...ger.ca>
Subject: Re: [PATCH] e2fsck: check xattr 'system.data' before setting
 inline_data feature

On Tue, Oct 30, 2018 at 05:15:01PM +1100, Li Dongyang wrote:
> ext2fs_inline_data_size will happy return 0 and set size to
> EXT4_MIN_INLINE_DATA_SIZE even when inode doesn't have
> xattr 'system.data', a corrupted i_flags could make e2fsck
> enable the inline_data on the superblock.
> 
> We should only offer to enable inline_data when i_flags is set
> and xattr 'system.data' can be found.
> 
> Signed-off-by: Li Dongyang <dongyangli@....com>

Thanks, applied.

					- Ted

Powered by blists - more mailing lists