linux-ext4 - Re: [v2] e2fsck: check xattr 'system.data' before setting inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181115181708.GA19411@thunk.org>
Date:   Thu, 15 Nov 2018 13:17:08 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Li Dongyang <dongyangli@....com>
Cc:     linux-ext4@...r.kernel.org, adilger@...ger.ca
Subject: Re: [v2] e2fsck: check xattr 'system.data' before setting
 inline_data feature

On Tue, Nov 13, 2018 at 03:46:03PM +1100, Li Dongyang wrote:
> ext2fs_inline_data_size will happy return 0 and set size to
> EXT4_MIN_INLINE_DATA_SIZE even when inode doesn't have
> xattr 'system.data', a corrupted i_flags could make e2fsck
> enable the inline_data on the superblock.
> 
> We should only offer to enable inline_data when i_flags is set
> and xattr 'system.data' can be found.
> 
> Also use correct prompt for PR_1_INLINE_DATA_FEATURE.
> 
> Signed-off-by: Li Dongyang <dongyangli@....com>

Thanks, applied.

					- Ted