linux-ext4 - Re: [PATCH] e2scrub: fix systemd escaping again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181115192058.GE20617@thunk.org>
Date:   Thu, 15 Nov 2018 14:20:58 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>
Cc:     linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] e2scrub: fix systemd escaping again

On Mon, Nov 05, 2018 at 09:59:46AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@...cle.com>
> 
> Apparently newer versions of systemd than the one on this author's
> laptop <cough> now complain about lack of (path) escaping in unit
> instance variable contents:
> 
>  # e2scrub_all
>  Scrubbing /home...
>  Invalid unit name "e2scrub@...me" was escaped as "e2scrub@...me"
>  (maybe you should use systemd-escape?)
>  Starting Online ext4 Metadata Check for /home...
> 
> So change the escape_path_for_systemd function to escape paths
> unconditionally to make the warning go away.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Thanks, applied.

					- Ted