lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 20 Nov 2018 21:35:07 -0800
From:   Sagi Grimberg <>
To:     Ming Lei <>
Cc:     Christoph Hellwig <>, Jens Axboe <>,,,, Dave Chinner <>,
        Kent Overstreet <>,
        Mike Snitzer <>,,
        Alexander Viro <>,, Shaohua Li <>,,,
        David Sterba <>,,
        "Darrick J . Wong" <>,, Gao Xiang <>,
        Theodore Ts'o <>,,
        Coly Li <>,,
        Boaz Harrosh <>,
        Bob Peterson <>,
Subject: Re: [PATCH V10 09/19] block: introduce bio_bvecs()

>> Wait, I see that the bvec is still a single array per bio. When you said
>> a table I thought you meant a 2-dimentional array...
> I mean a new 1-d table A has to be created for multiple bios in one rq,
> and build it in the following way
>             rq_for_each_bvec(tmp, rq, rq_iter)
>                      *A = tmp;
> Then you can pass A to iov_iter_bvec() & send().
> Given it is over TCP, I guess it should be doable for you to preallocate one
> 256-bvec table in one page for each request, then sets the max segment size as
> (unsigned int)-1, and max segment number as 256, the preallocated table
> should work anytime.

256 bvec table is really a lot to preallocate, especially when its not
needed, I can easily initialize the bvec_iter on the bio bvec. If this
involves preallocation of the worst-case than I don't consider this to
be an improvement.

Powered by blists - more mailing lists