linux-ext4 - Re: [PATCH e2fsprogs 9/9] tune2fs: Prevent enabling encryption flag on encoding-aware fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d0qydxiy.fsf@collabora.com>
Date:   Wed, 21 Nov 2018 14:46:13 -0500
From:   Gabriel Krisman Bertazi <krisman@...labora.com>
To:     "Theodore Y. Ts'o" <tytso@....edu>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH e2fsprogs 9/9] tune2fs: Prevent enabling encryption flag on encoding-aware fs

"Theodore Y. Ts'o" <tytso@....edu> writes:

> On Mon, Oct 15, 2018 at 05:12:20PM -0400, Gabriel Krisman Bertazi wrote:
>> The kernel will refuse to mount filesystems with the encryption and
>> encoding features enabled at the same time.  The encoding feature can
>> only be set at mount time, so we can just prevent encryption from being
>> set at a later time by tune2fs.
>> 
>> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.co.uk>
>
> This check also needs to be in mke2fs, right?  I don't think I saw it
> in your mke2fs patch.

I hadn't noticed you could set the encryption flag at mkfs time.
sorry.  will fix in v3.
-- 
Gabriel Krisman Bertazi