linux-ext4 - Re: [PATCH V12 06/20] block: rename bvec helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Nov 2018 09:17:16 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     ming.lei@...hat.com
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Linux-MM <linux-mm@...ck.org>, "Ted Ts'o" <tytso@....edu>,
        osandov@...com, sagi@...mberg.me, dchinner@...hat.com,
        kent.overstreet@...il.com, snitzer@...hat.com, dm-devel@...hat.com,
        Al Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, shli@...nel.org,
        linux-raid@...r.kernel.org, David Sterba <dsterba@...e.com>,
        Linux Btrfs <linux-btrfs@...r.kernel.org>,
        darrick.wong@...cle.com, linux-xfs@...r.kernel.org,
        gaoxiang25@...wei.com, hch@....de,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        colyli@...e.de, linux-bcache@...r.kernel.org, ooo@...ctrozaur.com,
        rpeterso@...hat.com, cluster-devel@...hat.com
Subject: Re: [PATCH V12 06/20] block: rename bvec helpers

On Mon, Nov 26, 2018 at 3:20 AM Ming Lei <ming.lei@...hat.com> wrote:
>
> We will support multi-page bvec soon, and have to deal with
> single-page vs multi-page bvec. This patch follows Christoph's
> suggestion to rename all the following helpers:
>
>         for_each_bvec
>         bvec_iter_bvec
>         bvec_iter_len
>         bvec_iter_page
>         bvec_iter_offset
>
> into:
>         for_each_segment
>         segment_iter_bvec
>         segment_iter_len
>         segment_iter_page
>         segment_iter_offset
>
> so that these helpers named with 'segment' only deal with single-page
> bvec, or called segment. We will introduce helpers named with 'bvec'
> for multi-page bvec.
>
> bvec_iter_advance() isn't renamed becasue this helper is always operated
> on real bvec even though multi-page bvec is supported.
>
> Suggested-by: Christoph Hellwig <hch@....de>
> Signed-off-by: Ming Lei <ming.lei@...hat.com>
> ---
>  .clang-format                  |  2 +-

Acked-by: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>

Cheers,
Miguel