linux-ext4 - Re: [PATCH] ext2: initialize opts.s_mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181126145716.GC25835@quack2.suse.cz>
Date:   Mon, 26 Nov 2018 15:57:16 +0100
From:   Jan Kara <jack@...e.cz>
To:     Hou Tao <houtao1@...wei.com>
Cc:     linux-ext4@...r.kernel.org, xingaopeng@...wei.com, jack@...e.com
Subject: Re: [PATCH] ext2: initialize opts.s_mount_opt as zero before using it

On Sat 24-11-18 19:21:59, Hou Tao wrote:
> From: xingaopeng <xingaopeng@...wei.com>
> 
> We need to initialize opts.s_mount_opt as zero before using it, else we
> may get some unexpected mount options.
> 
> Fixes: 088519572ca8 ("ext2: Parse mount options into a dedicated structure")
> Signed-off-by: xingaopeng <xingaopeng@...wei.com>

Thanks for catching this! I've added the patch to my tree.

								Honza

> ---
>  fs/ext2/super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index cb91baa4275d..eb11502e3fcd 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -892,6 +892,7 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)
>  	if (sb->s_magic != EXT2_SUPER_MAGIC)
>  		goto cantfind_ext2;
>  
> +	opts.s_mount_opt = 0;
>  	/* Set defaults before we parse the mount options */
>  	def_mount_opts = le32_to_cpu(es->s_default_mount_opts);
>  	if (def_mount_opts & EXT2_DEFM_DEBUG)
> -- 
> 2.16.2.dirty
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR