lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 27 Nov 2018 15:54:28 +0100
From:   Alexander Lochmann <>
To:     Jan Kara <>
Cc:     Horst Schirmeier <>,
Subject: [PATCH] inode_has_no_xattr() does not use proper sync

inode.i_flags is modified without any proper
synchronisation used. inode_set_flags() is now used.

Found by LockDoc (Alexander Lochmann, Horst Schirmeier and Olaf

Signed-off-by: Alexander Lochmann <>
Signed-off-by: Horst Schirmeier <>
 include/linux/fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index c95c0807471f..54f3a21668a6 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3446,7 +3446,7 @@ static inline int check_sticky(struct inode *dir,
struct inode *inode)
 static inline void inode_has_no_xattr(struct inode *inode)
 	if (!is_sxid(inode->i_mode) && (inode->i_sb->s_flags & SB_NOSEC))
-		inode->i_flags |= S_NOSEC;
+		inode_set_flags(inode, S_NOSEC, S_NOSEC);

 static inline bool is_root_inode(struct inode *inode)

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists