[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Tue, 27 Nov 2018 15:54:28 +0100
From: Alexander Lochmann <alexander.lochmann@...dortmund.de>
To: Jan Kara <jack@...e.cz>
Cc: Horst Schirmeier <horst.schirmeier@...dortmund.de>,
linux-ext4@...r.kernel.org
Subject: [PATCH] inode_has_no_xattr() does not use proper sync
inode.i_flags is modified without any proper
synchronisation used. inode_set_flags() is now used.
Found by LockDoc (Alexander Lochmann, Horst Schirmeier and Olaf
Spinczyk)
Signed-off-by: Alexander Lochmann <alexander.lochmann@...dortmund.de>
Signed-off-by: Horst Schirmeier <horst.schirmeier@...dortmund.de>
---
include/linux/fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index c95c0807471f..54f3a21668a6 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3446,7 +3446,7 @@ static inline int check_sticky(struct inode *dir,
struct inode *inode)
static inline void inode_has_no_xattr(struct inode *inode)
{
if (!is_sxid(inode->i_mode) && (inode->i_sb->s_flags & SB_NOSEC))
- inode->i_flags |= S_NOSEC;
+ inode_set_flags(inode, S_NOSEC, S_NOSEC);
}
static inline bool is_root_inode(struct inode *inode)
--
2.19.1
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists