linux-ext4 - Re: [PATCH] Fix tst_super_size after ext2_super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <050FAC09-2437-417C-AF69-7637613BA7BB@dilger.ca>
Date:   Wed, 28 Nov 2018 12:09:26 -0700
From:   Andreas Dilger <adilger@...ger.ca>
To:     Artem Blagodarenko <artem.blagodarenko@...il.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] Fix tst_super_size after ext2_super_block changes

On Nov 28, 2018, at 9:08 AM, Artem Blagodarenko <artem.blagodarenko@...il.com> wrote:
> 
> Commits "Reserve feature bit and SB field bit for filename encoding"
> and "Add timestamp extension bits to superblock" change
> ext2_super_block structure, but don't change tst_super_size test,
> so "make check" fails with message:
> 
> error: s_reserved size 380 should be 392

How did these patches even land without "make check" being run once?
Does this test failure not cause "make check" to fail?

Anyway, you can add:

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> Signed-off-by: Artem Blagodarenko <artem.blagodarenko@...il.com>
> ---
> lib/ext2fs/tst_super_size.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/ext2fs/tst_super_size.c b/lib/ext2fs/tst_super_size.c
> index 0adac411..a932685d 100644
> --- a/lib/ext2fs/tst_super_size.c
> +++ b/lib/ext2fs/tst_super_size.c
> @@ -142,7 +142,16 @@ int main(int argc, char **argv)
> 	check_field(s_lpf_ino, 4);
> 	check_field(s_prj_quota_inum, 4);
> 	check_field(s_checksum_seed, 4);
> -	check_field(s_reserved, 98 * 4);
> +	check_field(s_wtime_hi, 1);
> +	check_field(s_mtime_hi, 1);
> +	check_field(s_mkfs_time_hi, 1);
> +	check_field(s_lastcheck_hi, 1);
> +	check_field(s_first_error_time_hi, 1);
> +	check_field(s_last_error_time_hi, 1);
> +	check_field(s_pad, 2);
> +	check_field(s_encoding, 2);
> +	check_field(s_encoding_flags, 2);
> +	check_field(s_reserved, 95 * 4);
> 	check_field(s_checksum, 4);
> 	do_field("Superblock end", 0, 0, cur_offset, 1024);
> #endif
> --
> 2.14.3
> 


Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)