lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 29 Nov 2018 10:04:50 +0100
From:   Michal Hocko <>
To:     Nikolay Borisov <>
Cc:, David Howells <>,
        Chris Mason <>, Josef Bacik <>,
        David Sterba <>,
        "Yan, Zheng" <>, Sage Weil <>,
        Ilya Dryomov <>,
        Steve French <>,
        Theodore Ts'o <>,
        Andreas Dilger <>,
        Mark Fasheh <>,
        Joel Becker <>,
        Mike Marshall <>,
        Martin Brandenburg <>,
        Andrew Morton <>,
        Mike Rapoport <>,
        Matthew Wilcox <>,
        Randy Dunlap <>,
        YueHaibing <>,
        Shakeel Butt <>,
        Dan Williams <>,,,,,,,,,
Subject: Re: [PATCH 2/2] fs: Don't open-code lru_to_page

On Thu 29-11-18 10:50:08, Nikolay Borisov wrote:
> On 29.11.18 г. 10:18 ч., Michal Hocko wrote:
> > On Thu 29-11-18 09:52:57, Nikolay Borisov wrote:
> >> There are a bunch of filesystems which essentially open-code lru_to_page
> >> helper. Change them to using the helper. No functional changes.
> > 
> > I would just squash the two into a single patch. It makes the first one
> > more obvious. Or is there any reason to have them separate?
> No reason, just didn't know how people would react so that's why I chose
> to send as two separate.

This is a matter of taste I guess. But I usually prefer to have callers
along with a new helper in a single patch. This is not a new helper
per-se but doing it the same way seems reasonable to me. Not that I
would insist of course. You can use my ack for both patch in case you
decide to leave it as is.

> If I squash them who would be the best person to take them ?

Sounds like a mmotm material to me.
Michal Hocko

Powered by blists - more mailing lists