linux-ext4 - Re: [PATCH] ext4: remove redundant condition check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181204052527.GG4981@thunk.org>
Date:   Tue, 4 Dec 2018 00:25:27 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     Chengguang Xu <cgxu519@....com>, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: remove redundant condition check

On Tue, Nov 27, 2018 at 10:43:58AM +0100, Jan Kara wrote:
> On Wed 14-11-18 07:24:48, Chengguang Xu wrote:
> > ext4_xattr_destroy_cache() can handle NULL pointer correctly,
> > so there is no need to check NULL pointer before calling
> > ext4_xattr_destroy_cache().
> > 
> > Signed-off-by: Chengguang Xu <cgxu519@....com>
> 
> The patch looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted