lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 22 Jan 2019 10:01:30 +0800
From:   Ming Lei <>
To:     Sagi Grimberg <>
Cc:     Jens Axboe <>,,,,
        Theodore Ts'o <>, Omar Sandoval <>,
        Dave Chinner <>,
        Kent Overstreet <>,
        Mike Snitzer <>,,
        Alexander Viro <>,,,
        David Sterba <>,,
        "Darrick J . Wong" <>,, Gao Xiang <>,
        Christoph Hellwig <>,,
        Coly Li <>,,
        Boaz Harrosh <>,
        Bob Peterson <>,
Subject: Re: [PATCH V14 00/18] block: support multi-page bvec

On Mon, Jan 21, 2019 at 01:43:21AM -0800, Sagi Grimberg wrote:
> > V14:
> > 	- drop patch(patch 4 in V13) for renaming bvec helpers, as suggested by Jens
> > 	- use mp_bvec_* as multi-page bvec helper name
> > 	- fix one build issue, which is caused by missing one converion of
> > 	bio_for_each_segment_all in fs/gfs2
> > 	- fix one 32bit ARCH specific issue caused by segment boundary mask
> > 	overflow
> Hey Ming,
> So is nvme-tcp also affected here? The only point where I see nvme-tcp
> can be affected is when initializing a bvec iter using bio_segments() as
> everywhere else we use iters which should transparently work..
> I see that loop was converted, does it mean that nvme-tcp needs to
> call something like?
> --
> 	bio_for_each_mp_bvec(bv, bio, iter)
> 		nr_bvecs++;

bio_for_each_segment()/bio_segments() still works, just not as efficient
as bio_for_each_mp_bvec() given each multi-page bvec(very similar with scatterlist)
is returned in each loop.

I don't look at nvme-tcp code yet. But if nvme-tcp supports this way,
it can benefit from bio_for_each_mp_bvec().


Powered by blists - more mailing lists