linux-ext4 - Re: [PATCH v2 1/2] e2fsck: allow to check >2GB sized directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Jan 2019 12:01:21 +0300
From:   Artem Blagodarenko <artem.blagodarenko@...il.com>
To:     linux-ext4 <linux-ext4@...r.kernel.org>
Cc:     adilger.kernel@...ger.ca
Subject: Re: [PATCH v2 1/2] e2fsck: allow to check >2GB sized directory

Hello, Theodore.

 Do I need fix something in this patch series?

Thank you.

> On 14 Dec 2018, at 10:50, Artem Blagodarenko <artem.blagodarenko@...il.com> wrote:
> 
> After large_dir feature has been added, e2fsprogs is
> ready for directories > 2GB, so we can remove e2fsck
> directory size check.
> 
> Signed-off-by: Artem Blagodarenko <artem.blagodarenko@...il.com>
> ---
> e2fsck/pass1.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c
> index 5c0b92d5..5c413610 100644
> --- a/e2fsck/pass1.c
> +++ b/e2fsck/pass1.c
> @@ -3647,9 +3647,12 @@ static int process_block(ext2_filsys fs,
> 		}
> 	}
> 
> -	if (p->is_dir && blockcnt > (1 << (21 - fs->super->s_log_block_size)))
> +	if (p->is_dir && !ext2fs_has_feature_largedir(fs->super) &&
> +	    blockcnt > (1 << (21 - fs->super->s_log_block_size)))
> 		problem = PR_1_TOOBIG_DIR;
> -	if (p->is_reg && p->num_blocks+1 >= p->max_blocks)
> +	if (p->is_dir && p->num_blocks + 1 >= p->max_blocks)
> +		problem = PR_1_TOOBIG_DIR;
> +	if (p->is_reg && p->num_blocks + 1 >= p->max_blocks)
> 		problem = PR_1_TOOBIG_REG;
> 	if (!p->is_dir && !p->is_reg && blockcnt > 0)
> 		problem = PR_1_TOOBIG_SYMLINK;
> -- 
> 2.14.3
>