linux-ext4 - Re: [PATCH] ext4: Replace opencoded i_writecount usage with inode_is_open_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190211040712.GD23000@mit.edu>
Date:   Sun, 10 Feb 2019 23:07:12 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Nikolay Borisov <nborisov@...e.com>
CC:     <adilger.kernel@...ger.ca>, <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: Replace opencoded i_writecount usage with
 inode_is_open_for_write

On Tue, Dec 11, 2018 at 10:23:55AM +0200, Nikolay Borisov wrote:
> There is a function which clearly conveys the objective of checking
> i_writecount. Additionally the usage in ext4_mb_initialize_context was
> wrong, since a node would have wrongfully been reported as writable if
> i_writecount had a negative value (MMAP_DENY_WRITE).
> 
> Reviewed-by: Jan Kara <jack@...e.cz>
> Signed-off-by: Nikolay Borisov <nborisov@...e.com>

Thanks, applied.

					- Ted