linux-ext4 - Re: [PATCH] libext2fs: revert "try to always use PUNCH_HOLE for unix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190214210448.GE7387@mit.edu>
Date:   Thu, 14 Feb 2019 16:04:48 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     "Darrick J. Wong" <darrick.wong@...cle.com>
CC:     linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] libext2fs: revert "try to always use PUNCH_HOLE for
 unix_discard"

On Mon, Jan 14, 2019 at 03:37:08PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@...cle.com>
> 
> Revert bcca9876a3428c10417c660b78933e6e70e8a5f5, because
> fallocate(PUNCH_HOLE) on block devices was changed to use zeroout
> instead of discard shortly after block device fallocate was merged.
> zeroout isn't necessarily a "drop storage" operation like discard is,
> so we prefer to use that on block devices.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>

Thanks, applied.

					- Ted