linux-ext4 - Re: [PATCH] ext2: Adjust the comment of function ext2_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190319104852.GB20138@quack2.suse.cz>
Date:   Tue, 19 Mar 2019 11:48:52 +0100
From:   Jan Kara <jack@...e.cz>
To:     Shuning Zhang <sunny.s.zhang@...cle.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext2: Adjust the comment of function ext2_alloc_branch

On Wed 06-03-19 09:47:35, Shuning Zhang wrote:
> The name of argument is error in the header comment.
> @num should be @indirect_blks.
> At the same time, there was a lack of description of the two parameters
> @blks and @goal.
> This commit therefore fixes this header comment.
> 
> Signed-off-by: Shuning Zhang <sunny.s.zhang@...cle.com>

Thanks. I've added the patch to my tree.

								Honza

> ---
>  fs/ext2/inode.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index e4bb938..3f404c3 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -451,7 +451,9 @@ static int ext2_alloc_blocks(struct inode *inode,
>  /**
>   *	ext2_alloc_branch - allocate and set up a chain of blocks.
>   *	@inode: owner
> - *	@num: depth of the chain (number of blocks to allocate)
> + *	@indirect_blks: depth of the chain (number of blocks to allocate)
> + *	@blks: number of allocated direct blocks
> + *	@goal: preferred place for allocation
>   *	@offsets: offsets (in the blocks) to store the pointers to next.
>   *	@branch: place to store the chain in.
>   *
> -- 
> 2.7.4
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR