lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Mar 2019 20:59:27 -0700 From: "Darrick J. Wong" <darrick.wong@...cle.com> To: "Theodore Ts'o" <tytso@....edu> Cc: Ext4 Developers List <linux-ext4@...r.kernel.org> Subject: Re: [PATCH 5/9] e2fscrub: add the -n option which shows what commands e2scrub would execute On Wed, Mar 20, 2019 at 10:02:14PM -0400, Theodore Ts'o wrote: > Signed-off-by: Theodore Ts'o <tytso@....edu> Looks ok, Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com> --D > --- > scrub/e2scrub.8.in | 5 +++++ > scrub/e2scrub.in | 6 ++++-- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/scrub/e2scrub.8.in b/scrub/e2scrub.8.in > index ff03523e3..7342876a3 100644 > --- a/scrub/e2scrub.8.in > +++ b/scrub/e2scrub.8.in > @@ -38,6 +38,11 @@ If the filesystem is not repaired, > will be run before the next mount. > .SH OPTIONS > .TP > +\fB-n\fR > +Print what commands > +.B e2scrub > +would execute (but don't actually execute them). > +.TP > \fB-r\fR > Remove the e2scrub snapshot and exit without checking anything. > .TP > diff --git a/scrub/e2scrub.in b/scrub/e2scrub.in > index 51a909373..301574968 100644 > --- a/scrub/e2scrub.in > +++ b/scrub/e2scrub.in > @@ -37,6 +37,7 @@ print_help() { > echo "Usage: $0 [OPTIONS] mountpoint | device" > echo > echo "mountpoint must be on a LVM-managed block device" > + echo "-n: Show what commands e2scrub would execute." > echo "-r: Remove e2scrub snapshot and exit, do not check anything." > echo "-t: Run fstrim if successful." > echo "-V: Print version information and exit." > @@ -68,8 +69,9 @@ exitcode() { > exit "${ret}" > } > > -while getopts "rtV" opt; do > - case "${opt}" in > +while getopts "nrtV" opt; do > + case "${opt}" in > + "n") DBG="echo Would execute: " ;; > "r") reap=1;; > "t") fstrim=1;; > "V") print_version; exitcode 0;; > -- > 2.19.1 >
Powered by blists - more mailing lists