lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Mar 2019 10:26:58 -0400 From: "Theodore Ts'o" <tytso@....edu> To: Lukas Czerner <lczerner@...hat.com> Cc: Ext4 Developers List <linux-ext4@...r.kernel.org>, darrick.wong@...cle.com Subject: Re: [PATCH 7/9] e2scrub_all: make sure there's enough free space for a snapshot On Thu, Mar 21, 2019 at 12:18:56PM +0100, Lukas Czerner wrote: > > So you're going to be calling vgs for every lvs even though you can have > a whole bunch of them in the same vg. That's not very efficient. > > You can just filter it out with the lvs at the start of the loop by > adding the proper select string. > > -S vg_free\>${snap_size_mb} Good point. BTW, that's why I had ignored one of your other suggestions --- I needed LVM_VG_NAME, which means I needed more than one output from lvs, so I use the output directly as you suggested. - Ted
Powered by blists - more mailing lists