linux-ext4 - Re: [PATCH 9/9] e2scrub,e2scrub_all: print a (more understandable) error if not run as root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Mar 2019 10:40:54 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Lukas Czerner <lczerner@...hat.com>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>,
        darrick.wong@...cle.com
Subject: Re: [PATCH 9/9] e2scrub,e2scrub_all: print a (more understandable)
 error if not run as root

On Thu, Mar 21, 2019 at 12:36:38PM +0100, Lukas Czerner wrote:
> 
> EUID is bashism and might not be available in a different shell. But I
> am sure we're using a lot of those and we have "#!/bin/bash".
> 
> It's just somehting to consider, because I am not sure if we say
> anywhere that those scripts will require bash. Personally I do not care
> too much, but I am using bash exclusively :)

Bash is considered "essential" by Debian so it's guaranteed to be
installed.  So I haven't really considered it high priority to try to
make it work on dash or pdksh or mksh or some other nitpicky POSIX.2
shell.

I assume that the right place to state this is in the RPM spec file
(it isn't not needed for debian/control since bash is an essential
package).

Shrug; I'd accept clean patches that allowed the use of a strict
POSIX.2-only shell, especially if there were distributions who cared
about this.  But I find it hard to get excited about it, personally.  :-)

					- Ted