linux-ext4 - Re: [PATCH] ext4: remove incorrect comment for NEXT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190329144836.GC16759@quack2.suse.cz>
Date:   Fri, 29 Mar 2019 15:48:36 +0100
From:   Jan Kara <jack@...e.cz>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: remove incorrect comment for NEXT_ORPHAN()

On Tue 19-03-19 13:38:18, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> The comment above NEXT_ORPHAN() was meant for ext4_encrypted_inode(),
> which was moved by commit a7550b30ab70 ("ext4 crypto: migrate into vfs's
> crypto engine") but the comment was accidentally left in place.  Since
> ext4_encrypted_inode() has now been removed, just remove the comment.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/ext4.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 82ffdacdc7fac..2a2e6ed9aab4f 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1592,9 +1592,6 @@ static inline void ext4_clear_state_flags(struct ext4_inode_info *ei)
>  #define EXT4_SB(sb)	(sb)
>  #endif
>  
> -/*
> - * Returns true if the inode is inode is encrypted
> - */
>  #define NEXT_ORPHAN(inode) EXT4_I(inode)->i_dtime
>  
>  /*
> -- 
> 2.21.0.225.g810b269d1ac-goog
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR