linux-ext4 - Re: [PATCH] generic: prohibit fstrim on journalled filesystems with norecovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190330101152.GB2824@desktop>
Date:   Sat, 30 Mar 2019 18:11:52 +0800
From:   Eryu Guan <guaneryu@...il.com>
To:     Filipe David Manana <fdmanana@...che.org>
Cc:     "Darrick J. Wong" <darrick.wong@...cle.com>,
        fstests <fstests@...r.kernel.org>,
        xfs <linux-xfs@...r.kernel.org>,
        linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] generic: prohibit fstrim on journalled filesystems with
 norecovery

On Tue, Mar 26, 2019 at 12:21:20PM +0000, Filipe David Manana wrote:
> On Sat, Mar 23, 2019 at 12:35 AM Darrick J. Wong
> <darrick.wong@...cle.com> wrote:
> >
> > From: Darrick J. Wong <darrick.wong@...cle.com>
> >
> > This test makes sure that we can't use stale unrecovered fs metadata to
> > drive a DISCARD festival on a disk and thereby destroy user data by
> > accident.
> 
> It would help to have listed the name of the patches that fix the
> issues on xfs/ext4/btrfs, to make it faster.

Yeah, I'm about to do that :)

> 
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@...cle.com>
> 
> Reviewed-by: Filipe Manana <fdmanana@...e.com>
> 
> Looks good, thanks for doing this. Just one question below.

Thanks for reviewing!

Eryu