linux-ext4 - Re: [PATCH RFC v6 04/11] unicode: reduce the size of utf8data[]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190406195342.GA18897@mit.edu>
Date:   Sat, 6 Apr 2019 15:53:42 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Gabriel Krisman Bertazi <krisman@...labora.com>
Cc:     linux-ext4@...r.kernel.org, sfrench@...ba.org,
        darrick.wong@...cle.com, jlayton@...nel.org, bfields@...ldses.org,
        paulus@...ba.org, linux-fsdevel@...r.kernel.org,
        Olaf Weber <olaf@....com>,
        Gabriel Krisman Bertazi <krisman@...labora.co.uk>
Subject: Re: [PATCH RFC v6 04/11] unicode: reduce the size of utf8data[]

On Mon, Mar 18, 2019 at 04:27:38PM -0400, Gabriel Krisman Bertazi wrote:
> From: Olaf Weber <olaf@....com>
> 
> Remove the Hangul decompositions from the utf8data trie, and do
> algorithmic decomposition to calculate them on the fly. To store
> the decomposition the caller of utf8lookup()/utf8nlookup() must
> provide a 12-byte buffer, which is used to synthesize a leaf with
> the decomposition. Trie size is reduced from 245kB to 90kB.

I'm seeing sizes much smaller; the actual utf8data[] array is 63,584.
And size utf8-norm.o reports:

   text	   data	    bss	    dec	    hex	filename
  68752	     96	      0	  68848	  10cf0	fs/unicode/utf8-norm.o

Were you measuring the size of the utf8-norm.o file?  That will vary
in size depending on whether debugging symbols are enabled, etc.

   		     	     	       	       - Ted