linux-ext4 - Re: [PATCH] ext4: Make sanity check in mballoc more strict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190406223521.GE18897@mit.edu>
Date:   Sat, 6 Apr 2019 18:35:21 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Make sanity check in mballoc more strict

On Thu, Mar 28, 2019 at 05:41:17PM +0100, Jan Kara wrote:
> Sanity check in mb_find_extent() only checked that returned extent does
> not extend past blocksize * 8, however it should not extend past
> EXT4_CLUSTERS_PER_GROUP(sb). This can happen when clusters_per_group <
> blocksize * 8 and the tail of the bitmap is not properly filled by 1s
> which happened e.g. when ancient kernels have grown the filesystem.
> 
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks, applied.

					- Ted