lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 16 Apr 2019 18:38:00 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-fscrypt@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] fscrypt: drop inode argument from fscrypt_get_ctx()

On Mon, Mar 18, 2019 at 10:23:33AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> The only reason the inode is being passed to fscrypt_get_ctx() is to
> verify that the encryption key is available.  However, all callers
> already ensure this because if we get as far as trying to do I/O to an
> encrypted file without the key, there's already a bug.
> 
> Therefore, remove this unnecessary argument.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Looks good, applied.

					- Ted

Powered by blists - more mailing lists