lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190422211717.GB22674@gmail.com> Date: Mon, 22 Apr 2019 14:17:18 -0700 From: Eric Biggers <ebiggers@...nel.org> To: Gabriel Krisman Bertazi <krisman@...labora.com> Cc: tytso@....edu, kernel@...labora.com, linux-ext4@...r.kernel.org, Gabriel Krisman Bertazi <krisman@...labora.co.uk> Subject: Re: [PATCH v4 4/9] lib/ext2fs: Implement NLS support On Fri, Nov 30, 2018 at 07:39:05PM -0500, Gabriel Krisman Bertazi wrote: > From: Gabriel Krisman Bertazi <krisman@...labora.co.uk> > > Basic NLS support is required in e2fsprogs because of fsck, which > needsto calculate dx hashes for encoding aware filesystems. this patch > implements this infrastructure as well as ascii support. > > We don't need to do all the dance of versioning as we do in the kernel, > because we know before-hand which encodings and versions we > support (those we know how to store in the sb), so it is simpler just to > create static tables. > > Changes since v3: > - Prevent buffer overflow during normalization/casefold. > - Signal invalid sequences and let caller handle it. > [...] > diff --git a/lib/ext2fs/nls_ascii.c b/lib/ext2fs/nls_ascii.c > new file mode 100644 > index 000000000000..5d513df404c1 > --- /dev/null > +++ b/lib/ext2fs/nls_ascii.c > @@ -0,0 +1,68 @@ > +#include "nls.h" > + > +#include <errno.h> > +#include <string.h> > + > + > +static unsigned char charset_tolower(const struct nls_table *table, > + unsigned int c) > +{ > + if (c >= 'A' && c <= 'Z') > + return (c | 0x20); > + return c; > +} Is charset_tolower() supposed to be used for something? It's never called. - Eric
Powered by blists - more mailing lists