lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <009c01d4f910$7db6ec40$7924c4c0$@samsung.com> Date: Mon, 22 Apr 2019 19:06:49 +0530 From: "kanchan" <joshi.k@...sung.com> To: "'Jens Axboe'" <axboe@...nel.dk>, <linux-kernel@...r.kernel.org>, <linux-block@...r.kernel.org>, <linux-nvme@...ts.infradead.org>, <linux-fsdevel@...r.kernel.org>, <linux-ext4@...r.kernel.org> Cc: <prakash.v@...sung.com> Subject: RE: [PATCH v4 4/7] block: introduce write-hint to stream-id conversion > Why not just use the bio write hint? We already disallow merging of dissimilar write hints, so req->bio->bi_write_hint is known to be identical with the rest of the bio's in that chain. Yes, that is better. Thanks for suggesting it. -----Original Message----- From: Jens Axboe [mailto:axboe@...nel.dk] Sent: Wednesday, April 17, 2019 11:28 PM To: Kanchan Joshi <joshi.k@...sung.com>; linux-kernel@...r.kernel.org; linux-block@...r.kernel.org; linux-nvme@...ts.infradead.org; linux-fsdevel@...r.kernel.org; linux-ext4@...r.kernel.org Cc: prakash.v@...sung.com Subject: Re: [PATCH v4 4/7] block: introduce write-hint to stream-id conversion On 4/17/19 11:50 AM, Kanchan Joshi wrote: > This patch moves write-hint-to-stream-id conversion in block-layer. > Earlier this was done by driver (nvme). Current conversion is of the > form "streamid = write-hint - 1", for both user and kernel streams. > Conversion takes stream limit (maintained in request queue) into > account. Write-hints beyond the exposed limit turn to 0. > A new field 'streamid' has been added in request. While 'write-hint' > field continues to exist. It keeps original value passed from upper > layer, and used during merging checks. Why not just use the bio write hint? We already disallow merging of dissimilar write hints, so req->bio->bi_write_hint is known to be identical with the rest of the bio's in that chain. -- Jens Axboe
Powered by blists - more mailing lists