linux-ext4 - Re: [PATCH] ext4: bad mount opts in no journal mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2C6C280A-9716-4F96-A999-CDFBD0153F61@akamai.com>
Date:   Tue, 23 Apr 2019 14:33:53 +0000
From:   "Banerjee, Debabrata" <dbanerje@...mai.com>
To:     Theodore Ts'o <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        Dmitry Monakhov <dmonakhov@...nvz.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ext4: bad mount opts in no journal mode

ping?

On 4/11/19, 5:49 PM, "Debabrata Banerjee" <dbanerje@...mai.com> wrote:

    Fixes:
    commit 1e381f60dad9 ("ext4: do not allow journal_opts for fs w/o journal")
    
    Instead of removing EXT4_MOUNT_JOURNAL_CHECKSUM from s_def_mount_opt as
    I assume was intended, all other options were blown away leading to
    _ext4_show_options() output being incorrect. I don't see why this or
    other journal related flags should be removed from s_def_mount_opt
    regardless, it is only used for comparison to display opts, and we
    already made sure they couldn't be set.
    
    Signed-off-by: Debabrata Banerjee <dbanerje@...mai.com>
    ---
     fs/ext4/super.c | 1 -
     1 file changed, 1 deletion(-)
    
    diff --git a/fs/ext4/super.c b/fs/ext4/super.c
    index 6ed4eb81e674..63eef29666e0 100644
    --- a/fs/ext4/super.c
    +++ b/fs/ext4/super.c
    @@ -4238,7 +4238,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
     				 "data=, fs mounted w/o journal");
     			goto failed_mount_wq;
     		}
    -		sbi->s_def_mount_opt &= EXT4_MOUNT_JOURNAL_CHECKSUM;
     		clear_opt(sb, JOURNAL_CHECKSUM);
     		clear_opt(sb, DATA_FLAGS);
     		sbi->s_journal = NULL;
    -- 
    2.21.0