linux-ext4 - Re: [PATCH v2] ext4: bad mount opts in no journal mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190501031125.GC5377@mit.edu>
Date:   Tue, 30 Apr 2019 23:11:25 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Debabrata Banerjee <dbanerje@...mai.com>
Cc:     Jan Kara <jack@...e.cz>, Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, Dmitry Monakhov <dmonakhov@...nvz.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ext4: bad mount opts in no journal mode

On Mon, Apr 29, 2019 at 01:31:58PM -0400, Debabrata Banerjee wrote:
> Fixes:
> commit 1e381f60dad9 ("ext4: do not allow journal_opts for fs w/o journal")
> 
> Instead of removing EXT4_MOUNT_JOURNAL_CHECKSUM from s_def_mount_opt as
> I assume was intended, all other options were blown away leading to
> _ext4_show_options() output being incorrect.
> 
> Signed-off-by: Debabrata Banerjee <dbanerje@...mai.com>

Thanks, applied.  Note that the Fixes line should like this:

Fixes: 1e381f60dad9 ("ext4: do not allow journal_opts for fs w/o journal")

... and be placed along with the Signed-off-by: headers.

    	   	  	     	 		- Ted