lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <85d0l0jzra.fsf@collabora.com> Date: Thu, 02 May 2019 17:46:33 -0400 From: Gabriel Krisman Bertazi <krisman@...labora.com> To: "Darrick J. Wong" <darrick.wong@...cle.com> Cc: "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org Subject: Re: Change feature name from fname_encoding to casefold? "Darrick J. Wong" <darrick.wong@...cle.com> writes: > On Thu, May 02, 2019 at 12:25:27PM -0400, Theodore Ts'o wrote: >> Given how we've simplified how we handle Unicode --- in particular, >> not doing any kind of normalization unless we are doing case-folding >> compares, I think it will be more user-friendly if we rename the >> feature from fname_encoding to casefold. > > TBH /me hadn't done enough reviewing even to notice the feature was > named 'fname_encoding' (whatever that means -- encoded how?). > IMHO 'casefold' is more descriptive about what the feature provides > (folding case for directory name comparisons, right?) > This name was accurate until the v6 of the patches. In v7, we decided to no longer apply file name encoding normalization system-wide during lookups, which changed the semantics of this feature flag. By that time, though, the name was already committed to e2fsprogs, so i didn't bother to change it. -- Gabriel Krisman Bertazi
Powered by blists - more mailing lists