[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+nGSuOgCAoS4MkbuSL2q5Gyi4jG2oyJqLu_sDgexm5fSBmPLQ@mail.gmail.com>
Date: Tue, 7 May 2019 12:24:32 -0700
From: Jakub StaroĊ <jstaron@...gle.com>
To: Pankaj Gupta <pagupta@...hat.com>
Cc: linux-nvdimm@...ts.01.org, linux-kernel@...r.kernel.org,
virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-acpi@...r.kernel.org,
qemu-devel@...gnu.org, linux-ext4@...r.kernel.org,
linux-xfs@...r.kernel.org, jack@...e.cz, mst@...hat.com,
jasowang@...hat.com, david@...morbit.com, lcapitulino@...hat.com,
adilger.kernel@...ger.ca, zwisler@...nel.org, aarcange@...hat.com,
dave.jiang@...el.com, darrick.wong@...cle.com,
vishal.l.verma@...el.com, david@...hat.com, willy@...radead.org,
hch@...radead.org, jmoyer@...hat.com, nilal@...hat.com,
lenb@...nel.org, kilobyte@...band.pl, riel@...riel.com,
yuval.shaia@...cle.com, stefanha@...hat.com, pbonzini@...hat.com,
dan.j.williams@...el.com, kwolf@...hat.com, tytso@....edu,
xiaoguangrong.eric@...il.com, cohuck@...hat.com, rjw@...ysocki.net,
imammedo@...hat.com, Stephen Barber <smbarber@...gle.com>
Subject: Re: [Qemu-devel] [PATCH v7 4/6] dax: check synchronous mapping is supported
From: Pankaj Gupta <pagupta@...hat.com>
Date: Thu, Apr 25, 2019 at 10:00 PM
> +static inline bool daxdev_mapping_supported(struct vm_area_struct *vma,
> + struct dax_device *dax_dev)
> +{
> + return !(vma->flags & VM_SYNC);
> +}
Shouldn't it be rather `return !(vma->vm_flags & VM_SYNC);`? There is
no field named `flags` in `struct vm_area_struct`.
Thank you,
Jakub
Powered by blists - more mailing lists