lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 May 2019 20:24:21 +0530 From: Pankaj Gupta <pagupta@...hat.com> To: linux-nvdimm@...ts.01.org, linux-kernel@...r.kernel.org, virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-acpi@...r.kernel.org, qemu-devel@...gnu.org, linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org Cc: dan.j.williams@...el.com, zwisler@...nel.org, vishal.l.verma@...el.com, dave.jiang@...el.com, mst@...hat.com, jasowang@...hat.com, willy@...radead.org, rjw@...ysocki.net, hch@...radead.org, lenb@...nel.org, jack@...e.cz, tytso@....edu, adilger.kernel@...ger.ca, darrick.wong@...cle.com, lcapitulino@...hat.com, kwolf@...hat.com, imammedo@...hat.com, jmoyer@...hat.com, nilal@...hat.com, riel@...riel.com, stefanha@...hat.com, aarcange@...hat.com, david@...hat.com, david@...morbit.com, cohuck@...hat.com, xiaoguangrong.eric@...il.com, pbonzini@...hat.com, kilobyte@...band.pl, yuval.shaia@...cle.com, jstaron@...gle.com, pagupta@...hat.com Subject: [PATCH v9 6/7] ext4: disable map_sync for async flush Dont support 'MAP_SYNC' with non-DAX files and DAX files with asynchronous dax_device. Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and ext4. Signed-off-by: Pankaj Gupta <pagupta@...hat.com> Reviewed-by: Jan Kara <jack@...e.cz> --- fs/ext4/file.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 98ec11f69cd4..dee549339e13 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c @@ -360,15 +360,17 @@ static const struct vm_operations_struct ext4_file_vm_ops = { static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma) { struct inode *inode = file->f_mapping->host; + struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb); + struct dax_device *dax_dev = sbi->s_daxdev; - if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb)))) + if (unlikely(ext4_forced_shutdown(sbi))) return -EIO; /* - * We don't support synchronous mappings for non-DAX files. At least - * until someone comes with a sensible use case. + * We don't support synchronous mappings for non-DAX files and + * for DAX files if underneath dax_device is not synchronous. */ - if (!IS_DAX(file_inode(file)) && (vma->vm_flags & VM_SYNC)) + if (!daxdev_mapping_supported(vma, dax_dev)) return -EOPNOTSUPP; file_accessed(file); -- 2.20.1
Powered by blists - more mailing lists