lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 May 2019 10:07:05 +0800 From: "cgxu519@...o.com.cn" <cgxu519@...o.com.cn> To: Jan Kara <jack@...e.cz> Cc: jack@...e.com, linux-ext4@...r.kernel.org Subject: Re: [PATCH] ext2: optimize ext2_xattr_get() On Thu, 2019-05-23 at 16:46 +0200, Jan Kara wrote: > On Tue 21-05-19 16:21:39, Chengguang Xu wrote: > > Since xattr entry names are sorted, we don't have > > to continue when current entry name is greater than > > target. > > > > Signed-off-by: Chengguang Xu <cgxu519@...o.com.cn> > > Thanks for the patch! If we are going to do these comparisons in multiple > places, then please create a helper function to do the comparison (so that > we have the same comparison in every place). Something like: > > int ext2_xattr_cmp(int name_index, size_t name_len, const char *name, > struct ext2_xattr_entry *entry) > Hi Jan, Thanks for the review and advice. You are right we should introduce a helper to handle this part of work and personally I think maybe implementing a helper to find target entry will be more useful, do you think it makes sense? Thanks, Chengguang
Powered by blists - more mailing lists