linux-ext4 - Re: [PATCH] e2fsck: handle verity files in scan_extent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190524043344.GF2532@mit.edu>
Date:   Fri, 24 May 2019 00:33:44 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] e2fsck: handle verity files in scan_extent_node()

On Thu, May 23, 2019 at 08:30:33AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Don't report PR_1_EXTENT_END_OUT_OF_BOUNDS on verity files during
> scan_extent_node(), since they will have blocks stored past i_size.
> 
> This was missed during the earlier fix because this check only triggers
> if the inode has enough extents to need at least one extent index node.
> 
> This bug is causing one of the fs-verity xfstests to fail with the
> reworked fs-verity patchset.
> 
> Fixes: 3baafde6a8ae ("e2fsck: allow verity files to have initialized blocks past i_size")
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Thanks, applied.

Could you supply a small (~200k) file system with a verity-protected
file so we can add a regression test?  Many thanks!!

     	       	     		       	    - Ted