linux-ext4 - Re: [PATCH] ext4: Fix dcache lookup of !casefolded directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190525035847.GC4225@mit.edu>
Date:   Fri, 24 May 2019 23:58:47 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Gabriel Krisman Bertazi <krisman@...labora.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Fix dcache lookup of !casefolded directories

On Fri, May 24, 2019 at 06:41:29PM -0400, Gabriel Krisman Bertazi wrote:
> Found by visual inspection, this wasn't caught by my xfstest, since it's
> effect is ignoring positive dentries in the cache the fallback just goes
> to the disk.  it was introduced in the last iteration of the
> case-insensitive patch.
> 
> d_compare should return 0 when the entries match, so make sure we are
> correctly comparing the entire string if the encoding feature is set and
> we are on a case-INsensitive directory.
> 
> Fixes: b886ee3e778e ("ext4: Support case-insensitive file name lookups")
> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com>

Applied, thanks.

I'll note that half the implementations of *_d_compare seem to use
!!memcmp(), and half use memcmp().

The callers of d_compare only seems to care if it's 0 or != 0, so I
guess it doesn't matter...

				- Ted