linux-ext4 - Re: [PATCH] ext2: code cleanup for ext2_preread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190528075213.GA9607@quack2.suse.cz>
Date:   Tue, 28 May 2019 09:52:13 +0200
From:   Jan Kara <jack@...e.cz>
To:     Chengguang Xu <cgxu519@...o.com.cn>
Cc:     jack@...e.com, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext2: code cleanup for ext2_preread_inode()

On Tue 28-05-19 13:32:31, Chengguang Xu wrote:
> Calling bdi_rw_congested() instead of calling
> bdi_read_congested() and bdi_write_congested().
> 
> Signed-off-by: Chengguang Xu <cgxu519@...o.com.cn>

Thanks! Applied.

							Honza

> ---
>  fs/ext2/ialloc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
> index a0c5ea91fcd4..334dea4e499d 100644
> --- a/fs/ext2/ialloc.c
> +++ b/fs/ext2/ialloc.c
> @@ -172,9 +172,7 @@ static void ext2_preread_inode(struct inode *inode)
>  	struct backing_dev_info *bdi;
>  
>  	bdi = inode_to_bdi(inode);
> -	if (bdi_read_congested(bdi))
> -		return;
> -	if (bdi_write_congested(bdi))
> +	if (bdi_rw_congested(bdi))
>  		return;
>  
>  	block_group = (inode->i_ino - 1) / EXT2_INODES_PER_GROUP(inode->i_sb);
> -- 
> 2.20.1
> 
> 
> 
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR