lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Jun 2019 22:08:02 +0530 From: Pankaj Gupta <pagupta@...hat.com> To: dm-devel@...hat.com, linux-nvdimm@...ts.01.org, linux-kernel@...r.kernel.org, virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-acpi@...r.kernel.org, qemu-devel@...gnu.org, linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org Cc: dan.j.williams@...el.com, zwisler@...nel.org, vishal.l.verma@...el.com, dave.jiang@...el.com, mst@...hat.com, jasowang@...hat.com, willy@...radead.org, rjw@...ysocki.net, hch@...radead.org, lenb@...nel.org, jack@...e.cz, tytso@....edu, adilger.kernel@...ger.ca, darrick.wong@...cle.com, lcapitulino@...hat.com, kwolf@...hat.com, imammedo@...hat.com, jmoyer@...hat.com, nilal@...hat.com, riel@...riel.com, stefanha@...hat.com, aarcange@...hat.com, david@...hat.com, david@...morbit.com, cohuck@...hat.com, xiaoguangrong.eric@...il.com, pagupta@...hat.com, pbonzini@...hat.com, yuval.shaia@...cle.com, kilobyte@...band.pl, jstaron@...gle.com, rdunlap@...radead.org, snitzer@...hat.com Subject: [PATCH v12 7/7] xfs: disable map_sync for async flush Dont support 'MAP_SYNC' with non-DAX files and DAX files with asynchronous dax_device. Virtio pmem provides asynchronous host page cache flush mechanism. We don't support 'MAP_SYNC' with virtio pmem and xfs. Signed-off-by: Pankaj Gupta <pagupta@...hat.com> Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com> --- fs/xfs/xfs_file.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index a7ceae90110e..f17652cca5ff 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -1203,11 +1203,14 @@ xfs_file_mmap( struct file *filp, struct vm_area_struct *vma) { + struct dax_device *dax_dev; + + dax_dev = xfs_find_daxdev_for_inode(file_inode(filp)); /* - * We don't support synchronous mappings for non-DAX files. At least - * until someone comes with a sensible use case. + * We don't support synchronous mappings for non-DAX files and + * for DAX files if underneath dax_device is not synchronous. */ - if (!IS_DAX(file_inode(filp)) && (vma->vm_flags & VM_SYNC)) + if (!daxdev_mapping_supported(vma, dax_dev)) return -EOPNOTSUPP; file_accessed(filp); -- 2.20.1
Powered by blists - more mailing lists