lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 16 Jun 2019 09:45:21 -0700 From: "Darrick J. Wong" <darrick.wong@...cle.com> To: Chengguang Xu <cgxu519@...o.com.cn> Cc: jack@...e.com, linux-ext4@...r.kernel.org Subject: Re: [PATCH] ext2: add missing brelse() in ext2_iget() On Sun, Jun 16, 2019 at 11:08:01PM +0800, Chengguang Xu wrote: > Add missing brelse() on error path of ext2_iget(). > > Signed-off-by: Chengguang Xu <cgxu519@...o.com.cn> /me wonders if the brelse ought to be moved down to bad_inode so that each error branch only has to set @ret and then jump (thereby eliminating the possibility of making this mistake again), but for a oneliner quick fix I guess it's fine: Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com> --D > --- > fs/ext2/inode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c > index e474127dd255..fb3611f02051 100644 > --- a/fs/ext2/inode.c > +++ b/fs/ext2/inode.c > @@ -1473,6 +1473,7 @@ struct inode *ext2_iget (struct super_block *sb, unsigned long ino) > else > ei->i_dir_acl = le32_to_cpu(raw_inode->i_dir_acl); > if (i_size_read(inode) < 0) { > + brelse(bh); > ret = -EFSCORRUPTED; > goto bad_inode; > } > -- > 2.21.0 > > >
Powered by blists - more mailing lists