lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 20 Jun 2019 14:34:54 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     "Theodore Ts'o" <tytso@....edu>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] jbd2: drop declaration of journal_sync_buffer()

On Thu, Jun 20, 2019 at 05:32:28PM -0400, Theodore Ts'o wrote:
> The journal_sync_buffer() function was never carried over from jbd to
> jbd2.  So get rid of the vestigal declaration of this (non-existent)
> function.
> 
> Signed-off-by: Theodore Ts'o <tytso@....edu>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

--D

> ---
>  fs/jbd2/journal.c    | 3 ---
>  include/linux/jbd2.h | 1 -
>  2 files changed, 4 deletions(-)
> 
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 17f679aeba7c..953990eb70a9 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -66,9 +66,6 @@ EXPORT_SYMBOL(jbd2_journal_get_undo_access);
>  EXPORT_SYMBOL(jbd2_journal_set_triggers);
>  EXPORT_SYMBOL(jbd2_journal_dirty_metadata);
>  EXPORT_SYMBOL(jbd2_journal_forget);
> -#if 0
> -EXPORT_SYMBOL(journal_sync_buffer);
> -#endif
>  EXPORT_SYMBOL(jbd2_journal_flush);
>  EXPORT_SYMBOL(jbd2_journal_revoke);
>  
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 0e0393e7f41a..df03825ad1a1 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -1373,7 +1373,6 @@ void		 jbd2_journal_set_triggers(struct buffer_head *,
>  					   struct jbd2_buffer_trigger_type *type);
>  extern int	 jbd2_journal_dirty_metadata (handle_t *, struct buffer_head *);
>  extern int	 jbd2_journal_forget (handle_t *, struct buffer_head *);
> -extern void	 journal_sync_buffer (struct buffer_head *);
>  extern int	 jbd2_journal_invalidatepage(journal_t *,
>  				struct page *, unsigned int, unsigned int);
>  extern int	 jbd2_journal_try_to_free_buffers(journal_t *, struct page *, gfp_t);
> -- 
> 2.22.0
> 

Powered by blists - more mailing lists