linux-ext4 - Re: [PATCH v2] ext4: fix warning when turn on dioread_nolock and inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190718150546.GA20078@mit.edu>
Date:   Thu, 18 Jul 2019 11:05:46 -0400
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     yangerkun <yangerkun@...wei.com>
Cc:     jack@...e.com, linux-ext4@...r.kernel.org, houtao1@...wei.com,
        yi.zhang@...wei.com, miaoxie@...wei.com
Subject: Re: [PATCH v2] ext4: fix warning when turn on dioread_nolock and
 inline_data

On Fri, Jul 05, 2019 at 04:01:34PM +0800, yangerkun wrote:
> mkfs.ext4 -O inline_data /dev/vdb
> mount -o dioread_nolock /dev/vdb /mnt
> echo "some inline data..." >> /mnt/test-file
> echo "some inline data..." >> /mnt/test-file
> sync
> 
> The above script will trigger "WARN_ON(!io_end->handle && sbi->s_journal)"
> because ext4_should_dioread_nolock() returns false for a file with inline
> data. Move the check to a place after we have already removed the inline
> data and prepared inode to write normal pages.
> 
> Reviewed-by: Jan Kara <jack@...e.cz>
> Signed-off-by: yangerkun <yangerkun@...wei.com>

Thanks, applied.

					- Ted