linux-ext4 - Re: [PATCH] po: remove unnecessary/buggy positional parameter specifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Aug 2019 12:13:16 +0200
From:   Benno Schulenberg <coordinator@...nslationproject.org>
To:     Theodore Ts'o <tytso@....edu>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>
Cc:     Trần Ngọc Quân <vnwildman@...il.com>
Subject: Re: [PATCH] po: remove unnecessary/buggy positional parameter
 specifiers


Op 13-07-19 om 18:57 schreef Theodore Ts'o:
> The strings in e2fsck/problem.c use a special %-expansion scheme,
> where %b gets expanded to a block number, %i gets expanded to an inode
> number, etc., where these values are in a problem context data
> structure.  As such, there is no need to use a printf style positional
> indicator (e.g., %2$s).  Indeed, the use of things like %1$i or %2$b
> will cause the %-expansion code to just print %1$i or %2$b, instead of
> the inode or block number, respectively.
> 
> Addresses-Debian-Bug: #892173

The proposed corrections have been applied by the translators to the Czech,
Dutch and German PO files, and manually by myself to the Vietnamese PO file .

Attached is a small patch to remove a superfluous no-c-format tag.

Benno

View attachment "0001-e2fsck-remove-an-ineffective-because-trailing-xgette.patch" of type "text/x-patch" (915 bytes)