linux-ext4 - Re: [PATCH 3/3] ext4: add a new ioctl EXT4_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190809191810.GA100971@gmail.com>
Date:   Fri, 9 Aug 2019 12:18:12 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Theodore Ts'o <tytso@....edu>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 3/3] ext4: add a new ioctl EXT4_IOC_GETSTATE

On Fri, Aug 09, 2019 at 02:18:31PM -0400, Theodore Ts'o wrote:
> The new ioctl EXT4_IOC_GETSTATE returns some of the dynamic state of
> an ext4 inode for debugging purposes.
> 
> Signed-off-by: Theodore Ts'o <tytso@....edu>
> ---
>  fs/ext4/ext4.h  | 11 +++++++++++
>  fs/ext4/ioctl.c | 17 +++++++++++++++++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index f6c305b43ffa..58b7a0905186 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -651,6 +651,7 @@ enum {
>  #define EXT4_IOC_GET_ENCRYPTION_POLICY	FS_IOC_GET_ENCRYPTION_POLICY
>  /* ioctl codes 19--2F are reserved for fscrypt */
>  #define EXT4_IOC_CLEAR_ES_CACHE		_IO('f', 30)
> +#define EXT4_IOC_GETSTATE		_IOW('f', 30, __u32)

30 == 0x1e overlaps with the range claimed to be reserved for fscrypt.

Also, these two new ioctls are both number 30, which means they can't be
controlled separately by SELinux, which only looks at the number.

- Eric