linux-ext4 - Re: [PATCH v3] ext4: fix potential use after free in system zone via remount with noblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190814111408.GC26273@quack2.suse.cz>
Date:   Wed, 14 Aug 2019 13:14:08 +0200
From:   Jan Kara <jack@...e.cz>
To:     "zhangyi (F)" <yi.zhang@...wei.com>
Cc:     linux-ext4@...r.kernel.org, tytso@....edu, jack@...e.cz,
        adilger.kernel@...ger.ca
Subject: Re: [PATCH v3] ext4: fix potential use after free in system zone via
 remount with noblock_validity

On Tue 13-08-19 21:05:47, zhangyi (F) wrote:
> Remount process will release system zone which was allocated before if
> "noblock_validity" is specified. If we mount an ext4 file system to two
> mountpoints with default mount options, and then remount one of them
> with "noblock_validity", it may trigger a use after free problem when
> someone accessing the other one.
> 
>  # mount /dev/sda foo
>  # mount /dev/sda bar
> 
> User access mountpoint "foo"   |   Remount mountpoint "bar"
>                                |
> ext4_map_blocks()              |   ext4_remount()
> check_block_validity()         |   ext4_setup_system_zone()
> ext4_data_block_valid()        |   ext4_release_system_zone()
>                                |   free system_blks rb nodes
> access system_blks rb nodes    |
> trigger use after free         |
> 
> This problem can also be reproduced by one mountpint, At the same time,
> add_system_zone() can get called during remount as well so there can be
> racing ext4_data_block_valid() reading the rbtree at the same time.
> 
> This patch add RCU to protect system zone from releasing or building
> when doing a remount which inverse current "noblock_validity" mount
> option. It assign the rbtree after the whole tree was complete and
> do actual freeing after rcu grace period, avoid any intermediate state.
> 
> Signed-off-by: zhangyi (F) <yi.zhang@...wei.com>
> ---
> Changes since v2:
>  - Remove seqlock, and assign the whole rbtree when finished assembling.
>  - Fix the sparse warning.

Thanks for the patch! It looks great to me. Just one nit below and with
that applied feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

>  int ext4_setup_system_zone(struct super_block *sb)
...
>  /* Called when the filesystem is unmounted */
>  void ext4_release_system_zone(struct super_block *sb)

Can you perhaps add a comment before ext4_setup_system_zone() and
ext4_release_system_zone() explaining that these two functions are called
under sb->s_umount semaphore protection which also serializes updates of
sb->system_blks pointer? Thanks!

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR