| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190821131813.9456-1-lczerner@redhat.com>
Date: Wed, 21 Aug 2019 15:18:12 +0200
From: Lukas Czerner <lczerner@...hat.com>
To: linux-ext4@...r.kernel.org
Subject: [PATCH 1/2] mke2fs: Warn if page size != blocksize when ecnrypt is enabled
With encrypt feature enabled the file system block size must match
system page size. Currently mke2fs will not complain at all when we try
to create a file system that does not satisfy this requirement for the
system. Add a warning for this case.
Signed-off-by: Lukas Czerner <lczerner@...hat.com>
---
misc/mke2fs.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index d7cf257e..aa9590d8 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -2468,6 +2468,26 @@ profile_error:
exit (1);
}
+ /*
+ * Encrypt feature requires blocksize to be the same as page size,
+ * otherwise file system won't mount
+ */
+ if (ext2fs_has_feature_encrypt(&fs_param) &&
+ (blocksize != sys_page_size)) {
+ if (!force) {
+ com_err(program_name, 0,
+ _("Encrypt feature is enabled, but block size "
+ "(%dB) does not match system page size "
+ "(%dB)"),
+ blocksize, sys_page_size);
+ proceed_question(proceed_delay);
+ }
+ fprintf(stderr,_("Warning: Encrypt feature enabled, but block "
+ "size (%dB) does not match system page size "
+ "(%dB), forced to continue\n"),
+ blocksize, sys_page_size);
+ }
+
/* Don't allow user to set both metadata_csum and uninit_bg bits. */
if (ext2fs_has_feature_metadata_csum(&fs_param) &&
ext2fs_has_feature_gdt_csum(&fs_param))
--
2.21.0
Powered by blists - more mailing lists