linux-ext4 - Re: [PATCH 6/9] dm crypt: support diskcipher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 23 Aug 2019 14:27:02 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     "boojin.kim" <boojin.kim@...sung.com>
Cc:     "'David S. Miller'" <davem@...emloft.net>,
        'Eric Biggers' <ebiggers@...nel.org>,
        "'Theodore Y. Ts'o'" <tytso@....edu>, 'Chao Yu' <chao@...nel.org>,
        'Jaegeuk Kim' <jaegeuk@...nel.org>,
        'Andreas Dilger' <adilger.kernel@...ger.ca>,
        dm-devel@...hat.com, 'Mike Snitzer' <snitzer@...hat.com>,
        'Alasdair Kergon' <agk@...hat.com>,
        'Jens Axboe' <axboe@...nel.dk>,
        'Krzysztof Kozlowski' <krzk@...nel.org>,
        'Kukjin Kim' <kgene@...nel.org>,
        'Jaehoon Chung' <jh80.chung@...sung.com>,
        'Ulf Hansson' <ulf.hansson@...aro.org>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-fscrypt@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, linux-block@...r.kernel.org,
        linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
        linux-arm-kernel@...ts.infradead.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 6/9] dm crypt: support diskcipher

On Fri, Aug 23, 2019 at 01:20:37PM +0900, boojin.kim wrote:
>
> If yes, I think the following API needs to be added to skcipher:  
> - _set(): BIO submitter (dm-crypt, f2fs, ext4) sets cipher to BIO.
> - _mergeable(): Block layer checks if two BIOs have the same cipher.
> - _get(): Storage driver gets cipher from BIO.
> - _set_crypt(): Storage driver gets crypto information from cipher and 
> writes it on the descriptor of Storage controller.
> Is it acceptable to skcipher ?

No.  If you're after total offload then the crypto API is not for
you.  What we can support is the offloading of encryption/decryption
over many sectors.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt