linux-ext4 - Re: [PATCH] ext4: change the type of ext4 cache stats to percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <31888086-9ad8-6442-cbf6-c777cbc4947c@hisilicon.com>
Date:   Tue, 27 Aug 2019 13:46:48 +0800
From:   Shaokun Zhang <zhangshaokun@...ilicon.com>
To:     "Theodore Y. Ts'o" <tytso@....edu>, <linux-ext4@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Yang Guo <guoyang2@...wei.com>,
        "Andreas Dilger" <adilger.kernel@...ger.ca>
Subject: Re: [PATCH] ext4: change the type of ext4 cache stats to
 percpu_counter to improve performance

Hi Theodore,

On 2019/8/26 23:57, Theodore Y. Ts'o wrote:
> On Mon, Aug 26, 2019 at 04:24:20PM +0800, Shaokun Zhang wrote:
>>> The other problem with this patch is that it initializes
>>> es_stats_cache_hits and es_stats_cache_miesses too late.  They will
>>> get used when the journal inode is loaded.  This is mostly harmless,
>>
>> I have checked it again, @es_stats_cache_hits and @es_stats_cache_miesses
>> have been initialized before the journal inode is loaded, Maybe I miss
>> something else?
> 
> No, sorry, that was my mistake.  I misread things when I was looking
> over your patch last night.
> 
> Please resubmit your patch once you've fixed things up and tested it.
> 

Sure, will do it soon.

> I would recommend that you at least try running your patch using the
> kvm-xfstests's smoke test[1] before submitting them.  It will save you
> and me time.
> 

Ok, thanks your guidance.

Shaokun,

> [1] https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md
> 
> Thanks,
> 
> 					- Ted
> 					
> 
> .
>