linux-ext4 - Re: [PATCH] ext4: disable mount with both dioread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12533d10-22e4-59bc-c7db-4c7ca5c2df69@linux.alibaba.com>
Date:   Mon, 2 Sep 2019 09:31:23 +0800
From:   Xiaoguang Wang <xiaoguang.wang@...ux.alibaba.com>
To:     linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: disable mount with both dioread_nolock and
 nodelalloc

hi,

Ping.
For this patch, I'm afraid someone else still takes effort to look into this issue.

Regards,
Xiaoguang Wang

> Mount with both dioread_nolock and nodelalloc will result in huge
> performance drop, which indeed is an known issue, so before we fix
> this issue, currently we disable this behaviour. Below test reproducer
> can reveal this performance drop.
> 
>      mount -o remount,dioread_nolock,delalloc /dev/vdb1
>      rm -f testfile
>      start_time=$(date +%s)
>      dd if=/dev/zero of=testfile bs=4096 count=$((1024*256))
>      sync
>      end_time=$(date +%s)
>      echo $((end_time - start_time))
> 
>      mount -o remount,dioread_nolock,nodelalloc /dev/vdb1
>      rm -f testfile
>      start_time=$(date +%s)
>      dd if=/dev/zero of=testfile bs=4096 count=$((1024*256))
>      sync
>      end_time=$(date +%s)
>      echo $((end_time - start_time))
> 
> Signed-off-by: Xiaoguang Wang <xiaoguang.wang@...ux.alibaba.com>
> ---
>   fs/ext4/super.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 4079605d437a..1a2b2c0cd1b8 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -2098,6 +2098,12 @@ static int parse_options(char *options, struct super_block *sb,
>   		int blocksize =
>   			BLOCK_SIZE << le32_to_cpu(sbi->s_es->s_log_block_size);
>   
> +		if (!test_opt(sb, DELALLOC)) {
> +			ext4_msg(sb, KERN_ERR, "can't mount with "
> +				 "both dioread_nolock and nodelalloc");
> +			return 0;
> +		}
> +
>   		if (blocksize < PAGE_SIZE) {
>   			ext4_msg(sb, KERN_ERR, "can't mount with "
>   				 "dioread_nolock if block size != PAGE_SIZE");
>