lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87sgoj2795.fsf@x220.int.ebiederm.org> Date: Wed, 25 Sep 2019 20:09:26 -0500 From: ebiederm@...ssion.com (Eric W. Biederman) To: Jann Horn <jannh@...gle.com> Cc: Andy Lutomirski <luto@...nel.org>, Theodore Tso <tytso@...gle.com>, LKML <linux-kernel@...r.kernel.org>, Linux API <linux-api@...r.kernel.org>, Kees Cook <keescook@...omium.org>, "Jason A. Donenfeld" <Jason@...c4.com>, "Ahmed S. Darwish" <darwish.07@...il.com>, Lennart Poettering <mzxreary@...inter.de>, "Alexander E. Patrakov" <patrakov@...il.com>, Michael Kerrisk <mtk.manpages@...il.com>, Willy Tarreau <w@....eu>, Matthew Garrett <mjg59@...f.ucam.org>, Ext4 Developers List <linux-ext4@...r.kernel.org>, linux-man <linux-man@...r.kernel.org> Subject: Re: [PATCH v2 7/7] random: Remove kernel.random.read_wakeup_threshold Jann Horn <jannh@...gle.com> writes: > On Fri, Sep 20, 2019 at 4:37 PM Andy Lutomirski <luto@...nel.org> wrote: >> It has no effect any more, so remove it. We can revert this if >> there is some user code that expects to be able to set this sysctl. >> >> Signed-off-by: Andy Lutomirski <luto@...nel.org> >> --- >> drivers/char/random.c | 18 +----------------- >> 1 file changed, 1 insertion(+), 17 deletions(-) >> >> diff --git a/drivers/char/random.c b/drivers/char/random.c > [...] >> - { >> - .procname = "read_wakeup_threshold", > > There's a line in bin_random_table in kernel/sysctl_binary.c that > refers to this sysctl, that should probably also be deleted? I think it should be safe to leave in kernel/sysctl_binary.c This reminds me. I think we may finally be at a point where we can remove practically all of kernel/sysctl_binary.c I need to double check but last I looked no distro enables COINFIG_SYSCTL_SYSCALL anymore. Ubunutu was the last distro I know of that enabled it, and I think it has been a year or more since Ubuntu disabled CONFIG_SYSCTL_SYSCALL. Eric
Powered by blists - more mailing lists