linux-ext4 - Re: [PATCH 17/19] jbd2: Rename h_buffer_credits to h_total

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191003215034.GF17911@quack2.suse.cz>
Date:   Thu, 3 Oct 2019 23:50:34 +0200
From:   Jan Kara <jack@...e.cz>
To:     "Theodore Y. Ts'o" <tytso@....edu>
Cc:     Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 17/19] jbd2: Rename h_buffer_credits to h_total_credits

On Thu 03-10-19 09:29:09, Theodore Y. Ts'o wrote:
> On Thu, Oct 03, 2019 at 10:33:16AM +0200, Jan Kara wrote:
> > 
> > I'm not yet sure about some failures in ext4/adv and ext4/bigalloc configs.
> > Where can I find what mkfs & mount options do you use for these? I've
> > looked at xfstests-bld but I didn't find the configs there... Thanks!
> 
> The configs are in [1] the mount options for adv and bigalloc are in
> [2] and [3], respectively.
> 
> [1] https://github.com/tytso/xfstests-bld/blob/master/kvm-xfstests/test-appliance/files/root/fs
> [2] https://github.com/tytso/xfstests-bld/blob/master/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/adv
> [3] https://github.com/tytso/xfstests-bld/blob/master/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/bigalloc

Thanks. Somehow I didn't see them.

> It shouldn't be terribly difficult for you to use kvm-xfstests on
> SuSE, if you just want to try using the test appliance directly.  I'm
> happy to update the documentation to include the necessary SuSE
> packages needed to run kvm-xfstests; it shouldn't be that hard to
> translate them from the Debian prerequisites to SuSE package names.
> See [4] for details.
> 
> [4] https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md

Yeah, I guess I should do that. The only problem with this is that I have
my own VM setup I use for xfstests runs (and other kernel debugging) and it
just works good enough that switching to using kvm-xfstests never gets high
enough on my todo list :). I'll give it more priority...

								Honza


> Note: if you want to run tests manually (which can be handy if you
> want to try tweaking the tests, just do this:
> 
> % kvm-xfstests shell
> ...
> root@...-xfstests:~# FSTESTSET=ext4/301
> root@...-xfstests:~# FSTESTCFG=adv
> root@...-xfstests:~# ./runtests.sh
> 
> The xfstests installation is in /root/xfstests.  Other valid settings
> for FSTESTCFG include: ext4/adv, ext4/all, btrfs/default, btrfs, xfs,
> nfs, nfs/loopback_v3, and so on.  See [1] for other fs configs that
> you can use for testing.
> 
> Cheers,
> 
> 							- Ted
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR