linux-ext4 - Re: [RFC 1/2] ext4: Move ext4 bmap to use iomap infrastructure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191016083108.GA30337@quack2.suse.cz>
Date:   Wed, 16 Oct 2019 10:31:08 +0200
From:   Jan Kara <jack@...e.cz>
To:     Ritesh Harjani <riteshh@...ux.ibm.com>
Cc:     linux-ext4@...r.kernel.org, adilger.kernel@...ger.ca, jack@...e.cz,
        tytso@....edu, mbobrowski@...browski.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [RFC 1/2] ext4: Move ext4 bmap to use iomap infrastructure.

On Tue 20-08-19 18:36:33, Ritesh Harjani wrote:
> ext4_iomap_begin is already implemented which provides
> ext4_map_blocks, so just move the API from
> generic_block_bmap to iomap_bmap for iomap conversion.
> 
> Signed-off-by: Ritesh Harjani <riteshh@...ux.ibm.com>

This seems to have fallen through the cracks. The patch looks OK, feel free
to add:

Reviewed-by: Jan Kara <jack@...e.cz>
	
								Honza

> ---
>  fs/ext4/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 420fe3deed39..d6a34214e9df 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -3355,7 +3355,7 @@ static sector_t ext4_bmap(struct address_space *mapping, sector_t block)
>  			return 0;
>  	}
>  
> -	return generic_block_bmap(mapping, block, ext4_get_block);
> +	return iomap_bmap(mapping, block, &ext4_iomap_ops);
>  }
>  
>  static int ext4_readpage(struct file *file, struct page *page)
> -- 
> 2.21.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR