[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 17 Oct 2019 09:03:04 -0400
From: "Theodore Y. Ts'o" <tytso@....edu>
To: Iurii Zaikin <yzaikin@...gle.com>
Cc: linux-kselftest@...r.kernel.org, linux-ext4@...r.kernel.org,
skhan@...uxfoundation.org, adilger.kernel@...ger.ca,
Tim.Bird@...y.com, kunit-dev@...glegroups.com,
brendanhiggins@...gle.com
Subject: Re: [PATCH linux-kselftest/test v5] ext4: add kunit test for
decoding extended timestamps
On Thu, Oct 17, 2019 at 08:55:53AM -0400, Theodore Y. Ts'o wrote:
> Minor nit. The above commit description would look nicer when looked
> at in "git log" when formatted as follows:
>
> --- cut here ---
>
> KUnit tests for decoding extended 64 bit timestamps that verify the
> seconds part of [a/c/m] timestamps in ext4 inode structs are decoded
> correctly.
>
> KUnit tests, which run on boot and output the results to the debug log
> in TAP format (http://testanything.org/) are only useful for kernel
> devs running KUnit test harness and are not for inclusion into a
> production build.
>
> Test data is derived from the table in the Inode Timestamps section of
> Documentation/filesystems/ext4/inodes.rst.
>
> --- cut here ---
Upon rereading, swapping the 2nd and 3rd paragraphis would read
better, I think.
- Ted
Powered by blists - more mailing lists